Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add /Shares related copy tests on ocis which are removed from core #4373

Merged
merged 2 commits into from
Sep 5, 2022
Merged

[tests-only][full-ci]Add /Shares related copy tests on ocis which are removed from core #4373

merged 2 commits into from
Sep 5, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Aug 10, 2022

Description

This PR adds the tests for copy properties related to /Shares which is removed from this PR owncloud/core#40278 as /Shares related implementation is not in core and is shifted to ocis.

Related issue

#4154 (comment)

Note: Most of the tests for the copy is run from core API suites on ocis. This test added on ocis is only related to /Shares (Shares Jail)

@SagarGi SagarGi changed the title [tests-only][full-ci]Add /Shares related copy tests on ocis which are removed from core [tests-only][full-ci]Add /Shares related copy tests on ocis which are removed from core Aug 10, 2022
@SagarGi SagarGi self-assigned this Aug 10, 2022
@SagarGi SagarGi mentioned this pull request Aug 10, 2022
Closed
2 tasks
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch 4 times, most recently from 6cb2b34 to 27a9215 Compare August 15, 2022 09:18
@SagarGi SagarGi marked this pull request as ready for review August 15, 2022 10:10
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from 27a9215 to b668aca Compare August 18, 2022 03:27
@SagarGi SagarGi requested a review from grgprarup August 18, 2022 03:28
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from b668aca to b2af473 Compare August 18, 2022 06:59
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from b2af473 to 906d478 Compare August 18, 2022 08:01
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from 906d478 to 4cc6b6c Compare August 18, 2022 09:34
saw-jan
saw-jan reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sushmita56
sushmita56 reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@sushmita56 sushmita56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from 4cc6b6c to dcc5636 Compare August 22, 2022 03:25
@SagarGi
Copy link
Member Author

SagarGi commented Aug 22, 2022

NOTE: The tests related(added) to this is already removed from expected to failure already.

individual-it
individual-it requested changes Aug 22, 2022
View reviewed changes
tests/acceptance/features/apiSpaces/copySpaces.feature Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch 4 times, most recently from b49efbc to 1113d86 Compare August 26, 2022 06:37
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from 1113d86 to 2bf246f Compare August 29, 2022 08:45
individual-it
individual-it requested changes Aug 31, 2022
View reviewed changes
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from 2bf246f to 1dd3bd3 Compare September 1, 2022 09:39
@SagarGi SagarGi force-pushed the addTestForCopyForSharesJailOnOcis branch from 1dd3bd3 to 0bb94fa Compare September 1, 2022 10:02
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi merged commit c87de76 into master Sep 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the addTestForCopyForSharesJailOnOcis branch September 5, 2022 03:34
ownclouders pushed a commit that referenced this pull request Sep 5, 2022
@SagarGi
commit c87de76
2eb68c6 
Merge: 7c8aead 0bb94fa
Author: Sagar Gurung <46086950+SagarGi@users.noreply.github.com>
Date:   Mon Sep 5 09:18:58 2022 +0545

    Merge pull request #4373 from owncloud/addTestForCopyForSharesJailOnOcis

    [tests-only][full-ci]Add `/Shares` related copy tests on ocis which are removed from core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@saw-jan saw-jan saw-jan left review comments

@sushmita56 sushmita56 sushmita56 left review comments

@individual-it individual-it individual-it approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SagarGi @individual-it @grgprarup @kiranparajuli589 @SwikritiT @saw-jan @amrita-shrestha @sushmita56