Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile time options after switch to v2 #3694

Merged
merged 1 commit into from
May 5, 2022
Merged

fix compile time options after switch to v2 #3694

merged 1 commit into from
May 5, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 5, 2022

Description

adapts compile time options after switch to v2

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 5, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek mentioned this pull request May 5, 2022
Closed
45 tasks
@ownclouders
Copy link
Contributor

ownclouders commented May 5, 2022 •
edited
Loading

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

dragonchaser
dragonchaser approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek mentioned this pull request May 5, 2022
Merged
9 tasks
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit bba70c5 into owncloud:master May 5, 2022
@wkloucek wkloucek deleted the fix-compile-time-options branch May 5, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@micbar micbar Awaiting requested review from micbar

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker image: wrong configuration file location after ocis init
4 participants
@wkloucek @ownclouders @dragonchaser @butonic