Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] use new space ID util functions #3648

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented May 2, 2022

Description

Changed code to use the new space ID util functions so that everything works with the new spaces ID format.

Motivation and Context

We had multiple functions to parse or format the storage space id.
When we recently changed the format of the storage space id some places broke. Instead of just fixing the broken things locally I replaced it with the correct implementation from the Reva package. This package is used everywhere and will hopefully be kept compatible to the changing formats.
This will also fix thumbnails in spaces.
Needs this Reva PR first: cs3org/reva#2816.

How Has This Been Tested?

  • test environment: locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Code changes

@C0rby C0rby mentioned this pull request May 2, 2022
45 tasks
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@C0rby C0rby changed the title use new space ID util functions [full-ci] use new space ID util functions May 2, 2022
@C0rby C0rby marked this pull request as ready for review May 3, 2022 12:45
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

22.2% 22.2% Coverage
0.0% 0.0% Duplication

@C0rby C0rby merged commit 5a36f8f into master May 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the new-space-id-functions branch May 3, 2022 16:31
ownclouders pushed a commit that referenced this pull request May 3, 2022
Merge: a6c2956 958b4fe
Author: David Christofas <dchristofas@owncloud.com>
Date:   Tue May 3 18:31:09 2022 +0200

    Merge pull request #3648 from owncloud/new-space-id-functions

    [full-ci] use new space ID util functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants