Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce docker image volume permissions and update alpine #3641

Merged
merged 2 commits into from
May 3, 2022
Merged

reduce docker image volume permissions and update alpine #3641

merged 2 commits into from
May 3, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 2, 2022

Description

  • reduce volume permissions
  • update alpine base image

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from xoxys, C0rby and micbar May 2, 2022 07:03
@xoxys
Copy link
Contributor

xoxys commented May 2, 2022

Does 710 makes sense? Exec permissions (1) or read permissions (4) without the other will cause issues to read a directory/list files and is therefore useless IMO.

@wkloucek
Copy link
Contributor Author

wkloucek commented May 2, 2022

sues to read a directory/list files and is therefore useless IMO.

True, I took it from a random folder in my /var/lib/. Had another look at all of them and they have either 755 or 700. Therefore I'll change to 700

xoxys
xoxys approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the directory group is ocis-group I would use 750 at least but that's maybe just my personal preference.

@ownclouders
Copy link
Contributor

ownclouders commented May 2, 2022 •
edited
Loading

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-5 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 36a8fba into owncloud:master May 3, 2022
@wkloucek wkloucek deleted the docker_narrow_volume_permissions branch May 3, 2022 16:10
ownclouders pushed a commit that referenced this pull request May 3, 2022
@wkloucek
commit 36a8fba
03af29d 
Merge: a29d202 1e6b2fe
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue May 3 18:09:36 2022 +0200

    Merge pull request #3641 from wkloucek/docker_narrow_volume_permissions

    reduce docker image volume permissions and update alpine
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @xoxys @ownclouders