Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Switch UI tests to graphApi #3594

Merged
merged 8 commits into from
Apr 29, 2022
Merged

[full-ci] Switch UI tests to graphApi #3594

merged 8 commits into from
Apr 29, 2022

Conversation

ScharfViktor
Copy link
Contributor

@update-docs
Copy link

update-docs bot commented Apr 27, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor changed the title Switch UI tests to graphApi [full-ci] Switch UI tests to graphApi Apr 27, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Apr 27, 2022 •
edited
Loading

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@ScharfViktor ScharfViktor marked this pull request as ready for review April 27, 2022 14:19
rhafer
rhafer requested changes Apr 27, 2022
View reviewed changes
.drone.star Outdated Show resolved Hide resolved
@ScharfViktor
Update .drone.star
536c753 
change middleware tag
individual-it
individual-it reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group sharing seems not to work, I think the creation of groups was not implemented in the middleware yet with GraphAPI?

@ScharfViktor
Copy link
Contributor Author

group sharing seems not to work, I think the creation of groups was not implemented in the middleware yet with GraphAPI?

Yes, that was my mistake. Previosly I ran CI without [full-ci] so I didn't see all cases. It will be fixed

@micbar micbar mentioned this pull request Apr 29, 2022
Closed
45 tasks
@ScharfViktor ScharfViktor mentioned this pull request Apr 29, 2022
Merged
pascalwengerter
pascalwengerter previously requested changes Apr 29, 2022
View reviewed changes
.drone.star
@@ -698,7 +698,7 @@ def uiTestPipeline(ctx, filterTags, early_fail, runPart = 1, numberOfParts = 1,
"arch": "amd64",
},
"steps": skipIfUnchanged(ctx, "acceptance-tests") + restoreBuildArtifactCache(ctx, "ocis-binary-amd64", "ocis/bin/ocis") +
ocisServerWithAccounts(storage, accounts_hash_difficulty, [stepVolumeOC10Tests]) + waitForSeleniumService() + waitForMiddlewareService() + [
ocisServer(storage, accounts_hash_difficulty, [stepVolumeOC10Tests]) + waitForSeleniumService() + waitForMiddlewareService() + [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since ocisServerWithAccounts isn't being used anywhere else anymore I think you can also delete the function from the CI file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this can go a away. But IMO it's also fine to do this in a separate PR (if CI succeeds now)

.drone.env Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rhafer rhafer dismissed pascalwengerter’s stale review April 29, 2022 15:52

Will address in a followup PR

@rhafer rhafer merged commit 54ad9c3 into master Apr 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the switchUiTestToGraphApi branch April 29, 2022 15:52
ownclouders pushed a commit that referenced this pull request Apr 29, 2022
@ScharfViktor
commit 54ad9c3
2c5e6cf 
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Fri Apr 29 17:52:42 2022 +0200

    [full-ci] Switch UI tests to graphApi (#3594)

    * use ocis server in UI test and use middleware with changings

    * back to default middleware

    * Update .drone.star

    change middleware tag

    * run tests with my middleware image

    * use web commitId

    * change middleware version and web commit

    * back to webcommitID and add failed test to expected failures
ownclouders pushed a commit that referenced this pull request Apr 30, 2022
@ScharfViktor
commit 54ad9c3
68cc44d 
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Fri Apr 29 17:52:42 2022 +0200

    [full-ci] Switch UI tests to graphApi (#3594)

    * use ocis server in UI test and use middleware with changings

    * back to default middleware

    * Update .drone.star

    change middleware tag

    * run tests with my middleware image

    * use web commitId

    * change middleware version and web commit

    * back to webcommitID and add failed test to expected failures
ownclouders pushed a commit that referenced this pull request May 1, 2022
@ScharfViktor
commit 54ad9c3
556ba88 
Author: Viktor Scharf <scharf.vi@gmail.com>
Date:   Fri Apr 29 17:52:42 2022 +0200

    [full-ci] Switch UI tests to graphApi (#3594)

    * use ocis server in UI test and use middleware with changings

    * back to default middleware

    * Update .drone.star

    change middleware tag

    * run tests with my middleware image

    * use web commitId

    * change middleware version and web commit

    * back to webcommitID and add failed test to expected failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it left review comments

@rhafer rhafer rhafer approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScharfViktor @ownclouders @rhafer @individual-it @pascalwengerter