Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] config env #3589

Merged
merged 51 commits into from
May 3, 2022
Merged

[full-ci] config env #3589

merged 51 commits into from
May 3, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 26, 2022

Description

follow up on #3569

  • unify command structure
  • ensure all reva service register themselves at the registry
  • ensure all config options have yaml tags and env tags set (if applicable)
  • remove some configuration
  • remove some configuration from the documentation, if not in oCIS GA product scope (with omitempty tag and empty defaults and no env tag set, is still configurable via configuration file)
  • fix some ocis-config.Common copy operations to extension-config.Common operations
  • add configuration documentation for all service

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

.drone.star Outdated Show resolved Hide resolved
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage has been deleted, correct?

@wkloucek wkloucek changed the title config env [full-ci] config env May 3, 2022
@micbar micbar marked this pull request as ready for review May 3, 2022 16:06
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@@ -73,17 +73,6 @@ func SharingConfigFromStruct(cfg *config.Config) map[string]interface{} {
"enable_expired_shares_cleanup": cfg.PublicSharingDrivers.SQL.EnableExpiredSharesCleanup,
"janitor_run_interval": cfg.PublicSharingDrivers.SQL.JanitorRunInterval,
},
"owncloudsql": map[string]interface{}{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the PublicSharingDrivers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because there is no owncloudsql publicshare driver in reva: https://github.com/cs3org/reva/blob/afc8ead0c9a6a0acc5b46bf27a8b18ad458c098d/pkg/publicshare/manager/loader/loader.go#L23-L25

package loader

import (
	// Load core share manager drivers.
	_ "github.com/cs3org/reva/v2/pkg/publicshare/manager/cs3"
	_ "github.com/cs3org/reva/v2/pkg/publicshare/manager/json"
	_ "github.com/cs3org/reva/v2/pkg/publicshare/manager/memory"
	// Add your own here
)

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 50 Code Smells

0.1% 0.1% Coverage
65.1% 65.1% Duplication

@butonic butonic merged commit 706eb21 into owncloud:master May 3, 2022
ownclouders pushed a commit that referenced this pull request May 3, 2022
Merge: 932904f 3d2c804
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Tue May 3 21:52:04 2022 +0200

    Merge pull request #3589 from wkloucek/config-env

    [full-ci] config env
ownclouders pushed a commit that referenced this pull request May 4, 2022
Merge: 932904f 3d2c804
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Tue May 3 21:52:04 2022 +0200

    Merge pull request #3589 from wkloucek/config-env

    [full-ci] config env
@wkloucek wkloucek deleted the config-env branch May 4, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants