Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Switch default config from account/glauth to builtin libregraph/idm #3331

Merged
merged 7 commits into from
Apr 27, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Mar 16, 2022

Description

This switches the default configs of all required service to point to builtin libregraph/idm LDAP server. Also it disables the glauth and accounts services.

This PR includes the changes from #3323 (which be should hopefully merge before this)

Note: For now we still run the webUI test using the accounts service. Once the owncloud-test-middleware is update to use the GraphAPI for user provisioning those tests can be switched over to libregraph/idm as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@rhafer rhafer self-assigned this Mar 16, 2022
@update-docs
Copy link

update-docs bot commented Mar 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Mar 16, 2022

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@rhafer rhafer force-pushed the idm-default-cfg branch 3 times, most recently from 1db02ff to f01fd46 Compare March 22, 2022 14:09
@rhafer rhafer force-pushed the idm-default-cfg branch 8 times, most recently from 16d3d2b to 8e72080 Compare April 25, 2022 09:35
@ScharfViktor ScharfViktor changed the title Switch default config from account/glauth to builtin libregraph/idm [full-ci]Switch default config from account/glauth to builtin libregraph/idm Apr 25, 2022
@ScharfViktor ScharfViktor changed the title [full-ci]Switch default config from account/glauth to builtin libregraph/idm [full-ci] Switch default config from account/glauth to builtin libregraph/idm Apr 25, 2022
@rhafer rhafer force-pushed the idm-default-cfg branch 11 times, most recently from 128842b to fb97946 Compare April 26, 2022 11:45
@rhafer rhafer changed the title [full-ci] Switch default config from account/glauth to builtin libregraph/idm Switch default config from account/glauth to builtin libregraph/idm Apr 26, 2022
@rhafer rhafer force-pushed the idm-default-cfg branch 5 times, most recently from 4465fb8 to 27ef358 Compare April 26, 2022 16:36
- The accounts and glauth service are turned off by default
- proxy is switch from "accounts" to "cs3" for the account backend
- The LDAP configuration (graph, idp, storage) of all services now
  points to idm instead of glauth
Setup idp to verify the LDAP server certificate. As this certificate
might be generated on startup, this also moved the IDP to the "delayed"
set of services. So it starts after "idm".
@rhafer rhafer force-pushed the idm-default-cfg branch 2 times, most recently from 3efea5d to 3c7926a Compare April 26, 2022 17:45
@rhafer rhafer changed the title Switch default config from account/glauth to builtin libregraph/idm [full-ci] Switch default config from account/glauth to builtin libregraph/idm Apr 26, 2022
@rhafer rhafer marked this pull request as ready for review April 26, 2022 18:09
.drone.star Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
46.7% 46.7% Duplication

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome

@rhafer rhafer merged commit 0758854 into owncloud:master Apr 27, 2022
ownclouders pushed a commit that referenced this pull request Apr 27, 2022
Merge: 103abf8 aa7d75c
Author: Ralf Haferkamp <rhaferkamp@owncloud.com>
Date:   Wed Apr 27 10:08:13 2022 +0200

    Merge pull request #3331 from rhafer/idm-default-cfg

    [full-ci] Switch default config from account/glauth to builtin libregraph/idm
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants