Enh: First version of the notifications service #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled... |
kobergj
requested changes
Feb 23, 2022
C0rby
force-pushed
the
notifications-service
branch
from
15896b6
to
e160615
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kobergj
reviewed
Feb 23, 2022
|
Yeah, the question is what should we do about the groups topic? |
|
I am for merging now. Group functionality should go into refinement. |
|
@kobergj now? |
kobergj
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the minimal version of the notifications service to be able to notify a user when they received a share.
Currently the message is hard coded and there is only one communication channel for email. In the future we could have templated messages which could also be formatted by the the communication channel. Also a HTTP/REST service could be added to allow other services to send messages to users.
I implemented the functionality to also send messages to groups but this doesn't work currently since we don't have an authenticated context which we need to communicate with the gateway. On solution for this would be to have a service user but maybe we could have other solutions like mTLS for service to service communication?
@micbar should we tackle this in this PR still?
Motivation and Context
oCIS needs to be able to notify users in certain situations. The notifications service provides methods to communicate to the users via various channels.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: