bump reva and change nats port #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@rhafer This changes default NATS port. Please double-check if the port is allowed this time. I'll update https://github.com/owncloud/ocis/wiki/Official-Port-Ranges once this PR has landed |
kobergj
force-pushed
the
NatsServerImprovements
branch
from
81fb225
to
635dbb5
Compare
|
💥 Acceptance test Core-API-Tests-ocis-storage-4 failed. Further test are cancelled... |
|
Kudos, SonarCloud Quality Gate passed!
|
rhafer
approved these changes
Feb 22, 2022
| @@ -179,7 +179,7 @@ func sharingConfigFromStruct(c *cli.Context, cfg *config.Config) map[string]inte | |||
| "eventsmiddleware": map[string]interface{}{ | |||
| "group": "sharing", | |||
| "type": "nats", | |||
| "address": "127.0.0.1:4222", | |||
| "address": "127.0.0.1:9233", | |||
There was a problem hiding this comment.
Shouldn't this be configurable as well?
There was a problem hiding this comment.
This will be done with this PR: #3214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jkoberg jkoberg@owncloud.com
Description
Change Nats port and bump reva version
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: