-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align storage metadata GPRC bind port with other variable names #3169
fix: align storage metadata GPRC bind port with other variable names #3169
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This build has transient download issues in the docker image, can someone please re-run this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled... |
Currently STORAGE_METADATA_GRPC_PROVIDER_ADDR environment variable used as the way to set the GRPC bind port for the service. All other services use the format <SERVICE_NAME>_GRPC_ADDR for GRPC, and <SERVICE_NAME>_HTTP_ADDR for HTTP. This change brings it in line with the others, as it's confusing why this one is different.
75989e3
to
412d3e2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Currently STORAGE_METADATA_GRPC_PROVIDER_ADDR environment variable used as the way to set the GRPC bind port for the service. All other services use the format <SERVICE_NAME>_GRPC_ADDR for GRPC, and <SERVICE_NAME>_HTTP_ADDR for HTTP.
Motivation and Context
This change brings it in line with the others, as it's confusing why this one is different.
How Has This Been Tested?
Simple test is to run the following:
docker run -d --name ocis -e OCIS_RUN_EXTENSIONS="storage-metadata" -e STORAGE_METADATA_GRPC_ADDR="0.0.0.0:9215" owncloud/ocis
Check port this service is bound to (expect it to bind to external address):
docker exec -it ocis /usr/bin/nc -zv 172.17.0.2:9215
Expect to see:
172.17.0.2:9215 (172.17.0.2:9215) open
Types of changes
This is possibly a breaking change but a search of the source code finds no specific references to this variable anywhere.
Checklist: