-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Api test for adding space managers #3166
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled... |
Thanks for bringing it up. I'll try to fix it in this PR |
We can't share space with the manager's role. It still doesn't work for me: https://jira.owncloud.com/browse/OCIS-2095 still in progress |
this is broken in ocis master but already fixed in reva cs3org/reva@6ac2dfa |
I liked it because I could see the answer structure in the test I added a check that user has role in response. I tried combining these checks, but it didn't work for me |
65fc63f
to
974f3a3
Compare
LGTM, I cannot approve because I created it. Feel free to approve and merge. |
I cannot also because there is no "Approve button" available |
according to cs3org/reva#2524 the owner does not display in the space type project. |
aa7e824
to
78782d2
Compare
Needed a rebase. |
Thank @micbar for rebase. I merged it |
Author: Michael Barz <mbarz@owncloud.com> Date: Thu Feb 17 11:21:07 2022 +0100 add Api test for adding space managers (#3166) * add Api test for adding space managers * add cheking permissions in response * fix after rebase * only personal space dispayes owner Co-authored-by: Viktor Scharf <scharf.vi@gmail.com>
Description
Problem
the currentl logic parsing the json file and using specific key -> values breaks when we have unsorted lists.
We need to refactor this @phil-davis @ScharfViktor
Screenshots (if appropriate):
Types of changes
Checklist: