add permissions to the graph drives #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
C0rby
force-pushed
the
drive-permissions
branch
from
d0a98da
to
5950345
Compare
micbar
reviewed
Feb 4, 2022
|
💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled... |
C0rby
force-pushed
the
drive-permissions
branch
5 times, most recently
from
b8b240e
to
20204cb
Compare
C0rby
force-pushed
the
drive-permissions
branch
from
20204cb
to
5668a43
Compare
|
Kudos, SonarCloud Quality Gate passed! |
micbar
reviewed
Feb 4, 2022
| for id, perm := range m { | ||
| // This temporary variable is necessary since we need to pass a pointer to the | ||
| // libregraph.Identity and if we pass the pointer from the loop every identity | ||
| // will have the same id. |
micbar
reviewed
Feb 4, 2022
| tmp := id | ||
| identity := libregraph.IdentitySet{User: &libregraph.Identity{Id: &tmp}} | ||
| switch { | ||
| case perm.AddGrant: |
There was a problem hiding this comment.
so AddGrant is our reverse engineering criterium for the manager role.
There was a problem hiding this comment.
Yes, exactly. That's currently the only way.
micbar
approved these changes
Feb 4, 2022
kobergj
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added permissions to graph drives when listing drives.
A drive looks like this after this change:
{ "driveType": "personal", "id": "058bff95-6708-4fe5-91e4-9ea3d377588b", "lastModifiedDateTime": "2022-02-03T11:15:11.464382312+01:00", "name": "Maurice Moss", "owner": { "user": { "id": "058bff95-6708-4fe5-91e4-9ea3d377588b" } }, "root": { "id": "058bff95-6708-4fe5-91e4-9ea3d377588b", "permissions": [ { "grantedTo": [ { "user": { "id": "058bff95-6708-4fe5-91e4-9ea3d377588b" } } ], "roles": [ "manager" ] } ], "webDavUrl": "https://localhost:9200/dav/spaces/058bff95-6708-4fe5-91e4-9ea3d377588b" } }Motivation and Context
We want to see who has access to a space.
Types of changes
Checklist: