accounts now uses the same reva jwt secret as the metadata storage #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
force-pushed
the
metadata-service-jwt-token
branch
from
af90415
to
820e689
Compare
wkloucek
force-pushed
the
metadata-service-jwt-token
branch
from
820e689
to
f0d072e
Compare
wkloucek
requested review from
butonic,
C0rby,
micbar and
kobergj
and removed request for
kulmann and
pascalwengerter
|
Kudos, SonarCloud Quality Gate passed! |
C0rby
approved these changes
Feb 1, 2022
kobergj
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: use same jwt secret for accounts as for metadata storage
We've the metadata storage uses the same jwt secret as all other REVA services.
Therefore the accounts service needs to use the same secret.
Secrets are documented here: https://owncloud.dev/ocis/deployment/#change-default-secrets
Motivation and Context
Start oCIS with following environment variables:
and the accounts service can't write / read from the metadata storage...