Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default log level to error #3071

Merged
merged 4 commits into from
Feb 1, 2022
Merged

change default log level to error #3071

merged 4 commits into from
Feb 1, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 1, 2022

Description

The default log level is now "error"

@wkloucek wkloucek closed this Feb 1, 2022
@wkloucek wkloucek reopened this Feb 1, 2022
@@ -58,7 +58,7 @@ func NewLogger(opts ...Option) Logger {
zerolog.SetGlobalLevel(zerolog.DebugLevel)
mlog.SetLevel(mlog.LevelTrace)
default:
zerolog.SetGlobalLevel(zerolog.InfoLevel)
zerolog.SetGlobalLevel(zerolog.ErrorLevel)
mlog.SetLevel(mlog.LevelInfo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be changed to the error level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

changelog/unreleased/change-default-log-level.md Outdated Show resolved Hide resolved
@wkloucek wkloucek requested a review from C0rby February 1, 2022 09:35
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit b11e494 into master Feb 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the default_log_level_error branch February 1, 2022 12:01
ownclouders pushed a commit that referenced this pull request Feb 1, 2022
Merge: a1ce351 5b534f6
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Feb 1 13:01:40 2022 +0100

    Merge pull request #3071 from owncloud/default_log_level_error

    change default log level to error
@micbar micbar mentioned this pull request Feb 16, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants