Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing config fix #2952

Merged
merged 10 commits into from
Jan 13, 2022
Merged

Tracing config fix #2952

merged 10 commits into from
Jan 13, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 12, 2022 •
edited
Loading

Description

We've fixed the default tracing provider which was no longer configured after owncloud/ocis#2818.

Related Issue

  • Continuously deployed examples will work again

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from butonic, refs and micbar and removed request for kulmann and pascalwengerter January 12, 2022 09:30
@ownclouders
Copy link
Contributor

ownclouders commented Jan 12, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiAccountsHashDifficulty-ocis failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@wkloucek wkloucek force-pushed the tracing-config-fix branch 3 times, most recently from 79097b6 to c1e6b5f Compare January 12, 2022 10:46
@saw-jan
Copy link
Member

saw-jan commented Jan 12, 2022

@wkloucek you can cherry-pick from this PR #2951 and try if that works for running parallel deploy tests with pre-built ocis server

@kiranparajuli589 kiranparajuli589 mentioned this pull request Jan 12, 2022
Closed
9 tasks
@saw-jan saw-jan mentioned this pull request Jan 13, 2022
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
88.9% 88.9% Duplication

@wkloucek wkloucek merged commit 7cff81e into master Jan 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the tracing-config-fix branch January 13, 2022 07:42
@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@refs refs Awaiting requested review from refs

@micbar micbar Awaiting requested review from micbar

@individual-it individual-it Awaiting requested review from individual-it

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkloucek @ownclouders @saw-jan @butonic