Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adjust expected failures (apiFavorites) #2943

Merged
merged 1 commit into from
Jan 18, 2022
Merged

[tests-only][full-ci] adjust expected failures (apiFavorites) #2943

merged 1 commit into from
Jan 18, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 11, 2022 •
edited by phil-davis
Loading

Description

This PR adjusts the expected failures files after the tests related to the spaces webDAV added in apiFavorites folder.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@phil-davis
Copy link
Contributor

IMO this will need a change to the core commit id in .drone.env

@kiranparajuli589 kiranparajuli589 changed the title [tests-only][full-ci]Adjust Expected failures (apiFavorites) [tests-only][full-ci] adjust expected failures (apiFavorites) Jan 11, 2022
@amrita-shrestha amrita-shrestha force-pushed the update-favorites-expected-failure branch 4 times, most recently from 34a6fda to 635c8cf Compare January 12, 2022 05:22
@amrita-shrestha amrita-shrestha self-assigned this Jan 12, 2022
@amrita-shrestha amrita-shrestha force-pushed the update-favorites-expected-failure branch 6 times, most recently from a26db2f to 9a29c98 Compare January 14, 2022 17:28
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 14, 2022
Merged
6 tasks
@amrita-shrestha amrita-shrestha marked this pull request as draft January 17, 2022 04:06
@amrita-shrestha amrita-shrestha force-pushed the update-favorites-expected-failure branch 3 times, most recently from eb2f61b to cd87193 Compare January 18, 2022 03:55
phil-davis
phil-davis reviewed Jan 18, 2022
View reviewed changes
.drone.env Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the update-favorites-expected-failure branch from cd87193 to 5b23cd2 Compare January 18, 2022 04:18
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.1% 5.1% Coverage
23.2% 23.2% Duplication

@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 18, 2022 05:27
@phil-davis phil-davis merged commit aab34bd into owncloud:master Jan 18, 2022
@phil-davis phil-davis mentioned this pull request Jan 18, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@saw-jan saw-jan Awaiting requested review from saw-jan

@Talank Talank Awaiting requested review from Talank

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrita-shrestha @phil-davis