Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove non working proxy route and fix cs3 users example #2474

Merged
merged 2 commits into from
Sep 7, 2021
Merged

remove non working proxy route and fix cs3 users example #2474

merged 2 commits into from
Sep 7, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Sep 7, 2021 •
edited
Loading

Description

  • removed a non working route in the proxy default config
  • fixed the cs3 users example, since it still used the accounts service

@update-docs
Copy link

update-docs bot commented Sep 7, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review September 7, 2021 11:11
@wkloucek wkloucek requested a review from rhafer September 7, 2021 11:11
rhafer
rhafer approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit cac96b7 into master Sep 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove_non_working_route branch September 7, 2021 13:09
ownclouders pushed a commit that referenced this pull request Sep 7, 2021
@wkloucek
commit cac96b7
f60cc0e 
Merge: 7d26172 41ced66
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Sep 7 15:09:30 2021 +0200

    Merge pull request #2474 from owncloud/remove_non_working_route

    remove non working proxy route and fix cs3 users example
@micbar micbar mentioned this pull request Sep 15, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@rhafer rhafer rhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @rhafer @pascalwengerter