Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to go-chi/chi v5 #2429

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Move to go-chi/chi v5 #2429

merged 2 commits into from
Aug 25, 2021

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Aug 23, 2021

This moves us to the latest chi release

@rhafer rhafer requested a review from refs August 23, 2021 13:26
@rhafer rhafer self-assigned this Aug 23, 2021
@update-docs
Copy link

update-docs bot commented Aug 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer
Copy link
Contributor Author

rhafer commented Aug 24, 2021

This depends on owncloud/protoc-gen-microweb#7. Will update once that is merged.

@rhafer rhafer mentioned this pull request Aug 24, 2021
Merged
@refs
Copy link
Member

refs commented Aug 24, 2021

Just restarted CI. It looks it had some hiccups

image

@rhafer rhafer requested a review from lookacat as a code owner August 24, 2021 15:49
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.0% 23.0% Coverage
11.1% 11.1% Duplication

refs
refs approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@refs refs merged commit c996b64 into owncloud:master Aug 25, 2021
ownclouders pushed a commit that referenced this pull request Aug 25, 2021
@refs
commit c996b64
bddc7e2 
Merge: ea35cbb 3a42fdc
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Wed Aug 25 09:36:44 2021 +0200

    Merge pull request #2429 from rhafer/chi-v5
@rhafer rhafer deleted the chi-v5 branch August 26, 2021 09:07
@micbar micbar mentioned this pull request Sep 15, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@rhafer rhafer

Labels
Topic:Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhafer @refs