Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use claims map instead of struct #2315

Merged
merged 2 commits into from
Jul 22, 2021
Merged

use claims map instead of struct #2315

merged 2 commits into from
Jul 22, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 21, 2021

To be able to use custom OIDC claims when authenticating users we introduced two new parameters: PROXY_USER_OIDC_CLAIM=email and PROXY_USER_CS3_CLAIM=mail. The default will use the OIDC email claim to look up a user in the CS3 API with a mail claim. More robust mappings are recommended, eg. an ownclouduuid OIDC claim and an userid CS3 lookup.

@butonic butonic requested review from C0rby, refs and wkloucek July 21, 2021 15:39
@butonic butonic marked this pull request as ready for review July 21, 2021 17:00
@butonic butonic mentioned this pull request Jul 21, 2021
Merged
7 tasks
@butonic butonic force-pushed the claims-map-instead-of-struct branch from b438a0f to 1c4d40a Compare July 21, 2021 19:13
@butonic
Copy link
Member Author

butonic commented Jul 21, 2021 •
edited
Loading

  • increase code coverage!

@butonic butonic marked this pull request as draft July 21, 2021 20:49
@butonic butonic force-pushed the claims-map-instead-of-struct branch from 1c4d40a to 1f3e963 Compare July 22, 2021 09:15
@butonic butonic marked this pull request as ready for review July 22, 2021 09:16
@butonic
use claims map instead of struct
1f3e963 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
C0rby
C0rby approved these changes Jul 22, 2021
View reviewed changes
proxy/pkg/middleware/account_resolver.go Outdated Show resolved Hide resolved
proxy/pkg/middleware/account_resolver.go Outdated Show resolved Hide resolved
@butonic
use errors.Is()
2293403 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

62.3% 62.3% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 5de190b into master Jul 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the claims-map-instead-of-struct branch July 22, 2021 18:20
ownclouders pushed a commit that referenced this pull request Jul 22, 2021
@butonic
commit 5de190b
d4b4373 
Merge: c234c89 2293403
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Thu Jul 22 20:20:02 2021 +0200

    Merge pull request #2315 from owncloud/claims-map-instead-of-struct

    use claims map instead of struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@refs refs Awaiting requested review from refs

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @C0rby