Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the order where we ser STORAGE_METADATA_ROOT #1956

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Change the order where we ser STORAGE_METADATA_ROOT #1956

merged 3 commits into from
Apr 22, 2021

Conversation

refs
Copy link
Member

@refs refs commented Apr 22, 2021

closes #1955

@update-docs
Copy link

update-docs bot commented Apr 22, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs requested a review from butonic April 22, 2021 09:42
individual-it
individual-it approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue with the tests
the tests can now be run when ocis is started with the command mentioned in the docs

@refs
change the order where we ser STORAGE_METADATA_ROOT
dfb2bda 
add changelog

update root metadata location on ci

Revert "update root metadata location on ci"

This reverts commit a7bcf9d.

update .drone.star with no STORAGE_METADATA_ROOT

Revert "update .drone.star with no STORAGE_METADATA_ROOT"

This reverts commit 857db35.

Revert "change the order where we ser STORAGE_METADATA_ROOT"

This reverts commit 6f2c209.

Revert "Revert "update .drone.star with no STORAGE_METADATA_ROOT""

This reverts commit 64bfa3f.

Revert "Revert "Revert "update .drone.star with no STORAGE_METADATA_ROOT"""

This reverts commit 947ee03.
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@refs refs merged commit fa33963 into master Apr 22, 2021
@refs refs deleted the fix-1955 branch April 22, 2021 15:10
ownclouders pushed a commit that referenced this pull request Apr 22, 2021
@refs
commit fa33963
d7a1529 
Merge: 05f3b50 fefee56
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Thu Apr 22 17:10:53 2021 +0200

    Merge pull request #1956 from owncloud/fix-1955
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@butonic butonic Awaiting requested review from butonic

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unset STORAGE_METADATA_ROOT makes it impossible to run test cases locally
2 participants
@refs @individual-it