Remove Deprecations #10309
Remove Deprecations #10309
Conversation
kobergj
force-pushed
the
RemoveDeprecations
branch
from
ad753f9
to
ffb2d24
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
RemoveDeprecations
branch
from
ffb2d24
to
9f9a911
Compare
|
| case "kubernetes": | ||
| fmt.Println("Attention: kubernetes registry is deprecated, use nats-js-kv instead") | ||
| _reg = kubernetesr.NewRegistry() |
There was a problem hiding this comment.
I still think the kubernetes registry is the right one to use in kubernetes. That we moved to nats-js-kv was due to bugs and misconfiguration. We are currently creating dozens of nats connections, eg in the gateway, when we could reuse one connection: every go micro http/grpc client creates an internal registry cache. A different problem, but it tells me that we should not drop support for the kubernetes registry, yet.
There was a problem hiding this comment.
A way forward might be to use go grpc natively ... then we don't need the go micro registry at all. So, get rid of the kubernetes registry for now.
For reference, I dug into grpc connection management a while ago: #8589 (comment)
And we need to finish the ADR: #9488
Removes deprecated stores/caches/registries/envvars
Fixes #9938