Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

update reva #113

Merged
merged 13 commits into from
Mar 22, 2020
Merged

update reva #113

merged 13 commits into from
Mar 22, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 17, 2020

We changed the default configuration to integrate better with ocis.

  • We use ocis-glauth as the default ldap server on port 9125 with base dc=example,dc=org.
  • We use a dedicated technical reva user to make ldap binds
  • Clients are supposed to use the ocis-proxy endpoint https://localhost:9200
  • We removed unneeded ocis configuration from the frontend which no longer serves an oidc provider.
  • We changed the default user OpaqueID attribute from sub to preferred_username. The latter is a claim populated by konnectd that can also be used by the reva ldap user manager to look up users by their OpaqueId

Bugfix: we fixed a typo in the REVA_LDAP_SCHEMA_MAIL environment variable.

It was misspelled as REVA_LDAP_SCHEMA_Mail.

requires owncloud/ocis-glauth#9 and owncloud/ocis-konnectd#52

  • TODO fix testing.md, see .drone.star

@refs
Copy link
Member

refs commented Mar 17, 2020

Acceptance tests are off

@butonic
Copy link
Member Author

butonic commented Mar 17, 2020

I think because the root storage is no longer used ... will dig into it

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Member Author

butonic commented Mar 18, 2020

the path wrapping changed and trying to update the configs causes the acceptance tests to fail. I had to submit an upstream change to the owncloud storage driver to fix the general problem, but some tests are still off.

@butonic
Copy link
Member Author

butonic commented Mar 18, 2020

hmmm

242 scenarios (5 passed, 237 failed)
2653 | 1715 steps (134 passed, 237 failed, 1344 skipped)

vs locally

219 scenarios (181 passed, 38 failed)
1554 steps (1466 passed, 38 failed, 50 skipped)

…figuration

- Konnectd uses no TLS as it is behind the proxy.
- Glauth generates dev-certificates for ldap on startup if none is provided.
- Glauth can launch unencrypted (9125) and encrypted (9126) port in parallel

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic changed the title new ocis config update reva Mar 19, 2020
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Member Author

butonic commented Mar 20, 2020

@individual-it with owncloud/core#37149 the acceptance tests pass locally ... what is the process? change the core branch in the .drone.star to ocis-tests-expect-40x-on-not-exist, which should make this PR green, then merge core, then update this PR and revert to the core branch to master, wait for green light, merge?

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- pkg/flagset/storageocdata.go  3
- pkg/flagset/storageoc.go  3
- pkg/flagset/storagehome.go  4
- pkg/flagset/storagehomedata.go  3
- pkg/flagset/storageroot.go  3
- pkg/command/storageoc.go  1
         

Clones removed
==============
+ pkg/command/storagehome.go  -1
+ pkg/flagset/authbearer.go  -1
+ pkg/flagset/frontend.go  -1
         

See the complete overview on Codacy

@butonic butonic merged commit 7ae8fc2 into owncloud:master Mar 22, 2020
@butonic butonic deleted the config-changes branch March 22, 2020 08:56
ownclouders pushed a commit that referenced this pull request Mar 22, 2020
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Sun Mar 22 09:56:13 2020 +0100

    update reva (#113)

    * new ocis config

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * Change default settings to be able to run ocis server without any configuration

    - Konnectd uses no TLS as it is behind the proxy.
    - Glauth generates dev-certificates for ldap on startup if none is provided.
    - Glauth can launch unencrypted (9125) and encrypted (9126) port in parallel

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * allow configuring user sharing driver, default to json

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * update reva

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * switch to preferred_username as opaqueid

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * update drone config to override new defaults to match test environment

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * use latest reva

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * typo

    * use updatet api tests

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * core tests got merged already

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * fix changelog

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants