Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add restoreVersion tests for issue 387 #388

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

phil-davis
Copy link
Contributor

That demonstrate the current "bad behaviour" of issue #387

The corresponding "good" tests in core are skipped by core PR owncloud/core#37969

When fixing the issue, those core restoreVersion tests need to be unskipped and made to pass. And the "bad behaviour" scenarios in this PR should fail, and can be deleted.

Note: apiFilesPrimaryS3 already exists in behat.yml but it has no scenarios, so it was not being run in CI. This PR adds the suite to drone CI.

@phil-davis
Copy link
Contributor Author

Note: CI will fail for the core tests, until core PR owncloud/core#37969 has been merged.

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/files_primary_s3/1906/15/12 - the "bad behavior" scenario passes.

@phil-davis phil-davis marked this pull request as ready for review October 2, 2020 06:18
@phil-davis phil-davis merged commit 67a689f into master Oct 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the restoreVersion-tests branch October 2, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants