Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10.2 Release Notes #967

Merged
merged 2 commits into from
May 15, 2019
Merged

10.2 Release Notes #967

merged 2 commits into from
May 15, 2019

Conversation

pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Apr 11, 2019

Draft for 10.2 release notes. Still some things missing.
@tomneedham can you check line 108, please?

@phil-davis @settermjd @PVince81 as usual :)

THX!

@pmaier1 pmaier1 self-assigned this Apr 11, 2019
@settermjd
Copy link
Contributor

I've started going through it, but will need a bit of time to complete the review. Is Monday okay?

@pmaier1
Copy link
Contributor Author

pmaier1 commented Apr 11, 2019 •
edited
Loading

I've started going through it, but will need a bit of time to complete the review. Is Monday okay?

We have time until the week of the 22nd. I just submitted early as I'm going to be on vac for the next week.

phil-davis
phil-davis reviewed Apr 11, 2019
View reviewed changes
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
@PVince81
Copy link
Contributor

settermjd added a commit that referenced this pull request Apr 15, 2019
@settermjd
Update reference to --group option of occ files:scan command
7138f3a 
This is in reference to
#967 (comment).
settermjd
settermjd previously approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@settermjd settermjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a series of updates and changes to the release notes. @pmaier1, please review and let me know if you're happy with them.

pmaier1
pmaier1 commented Apr 23, 2019
View reviewed changes
Copy link
Contributor Author

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX so far! Some comments.

mmattel pushed a commit that referenced this pull request Apr 25, 2019
@settermjd @mmattel
Update reference to --group option of occ files:scan command
d3a8ff0 
This is in reference to
#967 (comment).
@settermjd
Copy link
Contributor

@pmaier1, further change made. Is the PR ready to be published?

@settermjd
Copy link
Contributor

@pmaier1, can you review and let me know if you're happy with these changes?

pmaier1
pmaier1 commented May 8, 2019
View reviewed changes
Copy link
Contributor Author

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. After addressing those we should merge. Any further changes can be done in another PR if necessary. Thanks 👍

modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Outdated Show resolved Hide resolved
modules/admin_manual/pages/release_notes.adoc Show resolved Hide resolved
@pmaier1
Copy link
Contributor Author

pmaier1 commented May 9, 2019 •
edited
Loading

Please add this to the "For developers" section:
"* A capability has been added to the Capabilities API to allow clients to check whether the server supports the details parameter for private links, e.g., as a direct link to a resource's sharing or versions tab in the web interface https://github.com/owncloud/core/issues/35104[#35104]"

@pmaier1 pmaier1 mentioned this pull request May 9, 2019
Closed
@settermjd
Copy link
Contributor

@pmaier1, further thoughts?

@pmaier1
Copy link
Contributor Author

pmaier1 commented May 13, 2019

The section "More granular permissions for public links on folders" is not yet correct.

Please use (something like) this for the section:

With ownCloud Server 10.2 the former "Download / View / Upload" permission has been renamed to "Download / View / Edit" as this better reflects its behavior (full permissions).
Additionally, a new permission "Download / View / Upload" has been introduced which allows recipients to view, download and upload contents but not to make any changes to existing content (e.g., rename, move, delete, update). Another way of looking at it is as a public file drop folder for distributing and gathering information with a single link, yet which prevents recipients from altering the existing content.

@settermjd
Copy link
Contributor

@pmaier1, I've added your update to the changes for this PR.

@pmaier1
Copy link
Contributor Author

pmaier1 commented May 13, 2019

Great, thanks. I'm happy with the content now. Not sure why, but I can't approve the PR.

phil-davis
phil-davis previously approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@phil-davis
Copy link
Contributor

Great, thanks. I'm happy with the content now. Not sure why, but I can't approve the PR.

@pmaier1 you are the PR author

@pmaier1
Copy link
Contributor Author

pmaier1 commented May 13, 2019

@pmaier1 you are the PR author

LOL, indeed, omg :D

@settermjd
Copy link
Contributor

@pmaier1, is the PR ready to merge?

@pmaier1
Copy link
Contributor Author

pmaier1 commented May 14, 2019

@pmaier1, is the PR ready to merge?

Yes!

phil-davis pushed a commit that referenced this pull request May 14, 2019
@settermjd @phil-davis
Update reference to --group option of occ files:scan command
958becc 
This is in reference to
#967 (comment).
@phil-davis
Copy link
Contributor

I rebased to get the PR up-to-date with master docs branch.
Does somebody want to squash the commits here into just a few (or 1) commit?

@settermjd
Copy link
Contributor

@phil-davis, I'll get that squash done.

@pmaier1 @settermjd
10.2 Release Notes
b60309d 
- Grammar and spelling updates
- Update reference to --group option of occ files:scan command
  This is in reference to #967 (comment).
- Document further additions and changes in 10.2
- Make reference to pear/archive_tar more meaningful
- Revise the granular permissions change
- Update the 10.2.0 for developer's section
- Update the Store quota overrides statement
@settermjd
Copy link
Contributor

@phil-davis, squash done!

@settermjd settermjd merged commit 6ad0a70 into master May 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the pmaier1-patch-3 branch May 15, 2019 11:00
settermjd pushed a commit that referenced this pull request May 15, 2019
@pmaier1 @settermjd
[10.2] [PR 967] 10.2 Release Notes
188db64 
Backport of PR #967
@settermjd settermjd mentioned this pull request May 15, 2019
Merged
settermjd pushed a commit that referenced this pull request May 15, 2019
@pmaier1 @settermjd
[10.0] [PR 967] 10.2 Release Notes
da994dd 
Backport of PR #967
settermjd pushed a commit that referenced this pull request May 15, 2019
@pmaier1 @settermjd
[10.1] [PR 967] 10.2 Release Notes
5f977f6 
Backport of PR #967
This was referenced May 15, 2019
Merged
Merged
settermjd added a commit that referenced this pull request May 15, 2019
@settermjd
[10.2] [PR 967] 10.2 Release Notes (#1207)
30c03b6 
Backport of PR #967
settermjd added a commit that referenced this pull request May 15, 2019
@settermjd
[10.0] [PR 967] 10.2 Release Notes (#1208)
1bd198e 
Backport of PR #967
settermjd added a commit that referenced this pull request May 15, 2019
@settermjd
[10.1] [PR 967] 10.2 Release Notes (#1209)
bfc772e 
Backport of PR #967
settermjd pushed a commit that referenced this pull request Jul 22, 2019
@pmaier1 @settermjd
10.2 Release Notes (#967)
bb88d90 
- Grammar and spelling updates
- Update reference to --group option of occ files:scan command
  This is in reference to #967 (comment).
- Document further additions and changes in 10.2
- Make reference to pear/archive_tar more meaningful
- Revise the granular permissions change
- Update the 10.2.0 for developer's section
- Update the Store quota overrides statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@settermjd settermjd settermjd left review comments

@tomneedham tomneedham tomneedham left review comments

@individual-it individual-it individual-it left review comments

@mmattel mmattel mmattel left review comments

@sharidas sharidas sharidas left review comments

@phil-davis phil-davis phil-davis left review comments

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@pmaier1 pmaier1

Labels
waiting on feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pmaier1 @settermjd @PVince81 @phil-davis @tomneedham @individual-it @mmattel @sharidas