add curl proxy support. #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he rel documentation during packaging
|
should we name it curlproxy? these config items could also be used with other request to the outside. Not sure which that would be, but why start with limiting it to curl? |
Thanks Bart for the hint. This also switches "==" to "<>" and not the code actually works ;-)
|
@bartv2 Good point. I removed the "curl" part. Should be clearer now. |
|
@DeepDiver1975 @butonic @schiesbn @blizzz @bartv2 Could you review please? Or someone else? |
|
Can someone review this please? |
|
@karlitschek rebase is necessary - THX |
|
👍 |
|
Can we have another reviewer please? |
|
looks good 👍 |
New doc system
add a check and a warning if setlocale is working
Thanks Bart for the hint. This also switches "==" to "<>" and not the code actually works ;-)
…o add_curl_proxy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
#504
Please review.
Sorry for the second pull request. You shouldn't use git when you are in a hurry ;-)