Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Remove /Shares related tests for lock properties from core #40300

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[tests-only][full-ci]Remove /Shares related tests for lock properties from core #40300

merged 1 commit into from
Aug 22, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Aug 18, 2022

Description

The /Shares related for the spaces WebDAV is removed from core since this is to be implemented and run on ocis.

Related Issue

owncloud/ocis#4154 (comment)

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Aug 18, 2022
@SagarGi SagarGi changed the title Remove /Shares related tests for lock properties from core [tests-only][full-ci]Remove /Shares related tests for lock properties from core Aug 18, 2022
@SagarGi SagarGi force-pushed the removeSharesRealtedFromWebdavLockForsetTimeoutSharesToShares branch from 4175c4d to 000de3f Compare August 18, 2022 08:44
kiranparajuli589
kiranparajuli589 reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SagarGi SagarGi mentioned this pull request Aug 18, 2022
Closed
2 tasks
@owncloud owncloud deleted a comment from update-docs bot Aug 18, 2022
@phil-davis
Copy link
Contributor

Some pipelines in CI got "stuck". I cancelled and restarted drone CI.

@SagarGi SagarGi mentioned this pull request Aug 19, 2022
Closed
amrita-shrestha
amrita-shrestha reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SagarGi SagarGi force-pushed the removeSharesRealtedFromWebdavLockForsetTimeoutSharesToShares branch from 000de3f to a2fdd3a Compare August 22, 2022 03:21
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit e8c9fcc into master Aug 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the removeSharesRealtedFromWebdavLockForsetTimeoutSharesToShares branch August 22, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @phil-davis @kiranparajuli589 @amrita-shrestha