Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Remove /Shares related tests from core for etagPropagation #40288

Merged
merged 1 commit into from
Aug 16, 2022
Merged

[tests-only][full-ci]Remove /Shares related tests from core for etagPropagation #40288

merged 1 commit into from
Aug 16, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Aug 15, 2022

Description

The /Shares related for the spaces WebDAV is removed from core since this is to be implemented and run on ocis.

Related Issue

owncloud/ocis#4154 (comment)

Motivation and Context

How Has This Been Tested?

  • test environment:
  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Aug 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi changed the title [tests-onnly][full-ci]Remove /Shares related tests from core for etagPropagation [tests-only][full-ci]Remove /Shares related tests from core for etagPropagation Aug 16, 2022
kiranparajuli589
kiranparajuli589 reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

This was referenced Aug 16, 2022
Closed
Merged
@owncloud owncloud deleted a comment from update-docs bot Aug 16, 2022
@phil-davis phil-davis merged commit 735b10d into master Aug 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the removeSharesRealtedFromEtagPropagation branch August 16, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @phil-davis @kiranparajuli589 @SwikritiT