Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] API tests for etag propagation #37954

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Sep 28, 2020

Description

etag propagation tests

Related Issue

part of owncloud/product#144

Motivation and Context

OCIS has now etag propagation implemented in the OCIS-storage, that need to be tested

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #37954 into master will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37954   +/-   ##
=========================================
  Coverage     64.71%   64.72%           
- Complexity    19444    19445    +1     
=========================================
  Files          1286     1286           
  Lines         76021    76037   +16     
  Branches       1336     1336           
=========================================
+ Hits          49197    49213   +16     
  Misses        26430    26430           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <94.44%> (+<0.01%) 19445.00 <1.00> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
core/Command/Encryption/Disable.php 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27a6ba...b6cd845. Read the comment docs.

@individual-it
Copy link
Member Author

tests got skipped on OC storage driver because they seem to fail randomly, ticket to track the issue: owncloud/ocis#637

@phil-davis
Copy link
Contributor

phil-davis commented Oct 1, 2020

Do we also need to test this for shares?
When the sharee changes something in a share, then etag of the parent... folders changes for both the sharer and sharee.
And for the sharer changing something - the sharee sees etag changes (so that a client sync app run by the sharee will notice a change...)

Update: the issue owncloud/product#144 has items listed for testing shares, so that will be covered in future PRs.

Co-authored-by: Phil Davis <phil@jankaritech.com>
@individual-it
Copy link
Member Author

Do we also need to test this for shares?
When the sharee changes something in a share, then etag of the parent... folders changes for both the sharer and sharee.
And for the sharer changing something - the sharee sees etag changes (so that a client sync app run by the sharee will notice a change...)

yes we also need sharing tests, will do them in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants