Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Acceptance tests for issue 37883 #37889

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 7, 2020

Description

Add acceptance tests that define the good behavior and demonstrate the bad behavior for issue #37883

Add test scenarios that share into a Shares folder and examine the response fields when the share receiver accepts the share:

  1. the expected good behavior scenarios are in acceptSharesToSharesFolder.feature and are tagged skipOnOcV10 because they do not currently pass on oCV10. These will run on OCIS (and we will see if OCIS passes or not)

  2. the scenarios that demonstrate the bad behavior on oCV10 are in
    acceptSharesToSharesFolderOc10Issue37883.feature and are tagged notToImplementOnOCIS because we do not want to imitate this behavior on OCIS. Putting these scenarios in a separate feature file means that we can delete them when the issue is fixed in oCV10 and the line numbers of the good behavior scenarios in the other file will not need to change.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #37889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37889   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32723ab...d77f25e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants