[Tests-only] Adjust public link tests for download, upload and other operations #37552

PVince81 · 2020-06-18T09:15:47Z

Enabled some tests and tagged others that are not working yet.

For owncloud/ocis-reva#49.
A lot blocked by owncloud/ocis-reva#282

~~REQUIRES: Public Links Download / Upload cs3org/reva#822 for some tests to work.~~
~~REQUIRES: use gateway to resolve public share info cs3org/reva#872 for some tests to work.~~
REQUIRES: Implementation of file operations in public folder shares cs3org/reva#877

~~Still need to investigate some of the tests tagged with "issue-ocis-reva-49" where the download returns an empty string.~~

Raised and tagged issues:

Webdav PUT response must always be 201 for upload-only shares: https://github.com/owncloud/ocis-reva/issues/286
public link permission handling: https://github.com/owncloud/ocis-reva/issues/292
~~rename and delete not implemented in public links: Rename or delete file in public link share not implemented ocis-reva#293~~ resolved in the PR
prevent sharing root folder: https://github.com/owncloud/ocis-reva/issues/283
split old and new endpoint tests: Split old public API webdav tests from new public webdav tests ocis-reva#282
OCS API expiration date should allow dates without time component: OCS expiration date should accept date without time component ocis-reva#288
OCS API support for legacy "publicUpload" attribute OCS public link support for legacy publicUpload attribute ocis-reva#289 => fixed in ocis-reva 0.6.0 but tests remains disabled because of other issues
500 error instead of 404 when accessing non-existing link: https://github.com/owncloud/ocis-reva/issues/290
share_with field must contain special value for public links that have a password: Public link response share_with special value when password set ocis-reva#294
single file shares: Public link single file share ocis-reva#278

TODOs:

investigate why remaining tests tagged with @issue-ocis-reva-49 are failing with empty downloads in apiSharePublicLink1/createPublicLinkShare.feature
process the other test files:

codecov · 2020-06-18T12:04:18Z

Codecov Report

Merging #37552 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #37552      +/-   ##
============================================
- Coverage     64.67%   64.66%   -0.02%     
- Complexity    19339    19343       +4     
============================================
  Files          1279     1279              
  Lines         75573    75600      +27     
  Branches       1331     1333       +2     
============================================
+ Hits          48880    48885       +5     
- Misses        26301    26323      +22     
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.03% <ø> (-0.11%)`	`0.00 <ø> (ø)`
#phpunit	`65.83% <ø> (-0.01%)`	`19343.00 <ø> (+4.00)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
...s/dav/lib/Connector/Sabre/PublicDavLocksPlugin.php	`59.25% <0.00%> (-13.47%)`	`10.00% <0.00%> (+1.00%)`	⬇️
apps/files/lib/App.php	`20.00% <0.00%> (-5.00%)`	`3.00% <0.00%> (ø%)`
core/js/files/client.js	`79.94% <0.00%> (-3.49%)`	`0.00% <0.00%> (ø%)`
...ederatedfilesharing/lib/FederatedShareProvider.php	`63.36% <0.00%> (+0.52%)`	`94.00% <0.00%> (+3.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09aab4...3831752. Read the comment docs.

codecov · 2020-06-18T12:04:45Z

Codecov Report

Merging #37552 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37552   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19353    19353           
=========================================
  Files          1281     1281           
  Lines         75612    75612           
  Branches       1333     1333           
=========================================
  Hits          48925    48925           
  Misses        26295    26295           
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.03% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.88% <ø> (ø)`	`19353.00 <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ad0c7...9d143b4. Read the comment docs.

PVince81 · 2020-06-18T14:36:22Z

Squashed and pushed. Added some more tickets and excluded tests.

Still, I managed to enable a bunch of tests for public link upload, download, creation, etc. Updating and deleting is not implemented yet.

PVince81 · 2020-06-24T15:36:58Z

While splitting the "old public webdav" and "new public webdav" I came accross a test tagged with @issue-36055.
That test had the test steps commented out for the "new public webdav".

It turns out that this bit still doesn't work. I've now marked it as @skipOnOcV10 and reopened the ticket, see #36055 (comment)

@individual-it FYI

PVince81 · 2020-06-24T15:40:10Z

I ran the unskipped tests marked with issue 49 against the matching Reva PR that solves those: cs3org/reva#877

TEST_SERVER_URL=http://localhost:9140 \
TEST_EXTERNAL_USER_BACKENDS=true \
TEST_OCIS=true \
OCIS_REVA_DATA_ROOT=/var/tmp/reva/ \
SKELETON_DIR=$HOME/work/workspace/owncloud/apps-external/testing/data/apiSkeleton \
BEHAT_FILTER_TAGS='~@skipOnOcV10&&~@skipOnLDAP&&@TestAlsoOnExternalUserBackend&&~@local_storage&&@issue-ocis-reva-49&&~@skipOnOcis'

and they all pass:

21 scenarios (21 passed)
145 steps (145 passed)

please note that some are still skipped due to other issues, see OP for a listing of related issues to address separately.

PVince81 · 2020-06-24T15:40:53Z

we might want to wait for the Reva PRs to be merged and updated in ocis-reva just to be on the safe side

individual-it · 2020-06-25T06:52:08Z

tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature

+      | uid_file_owner         | Alice           |
+      | uid_owner              | Alice           |
+      | name                   |                 |
+    When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API


Suggested change

When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API

When the public downloads the last public shared file with range "bytes=0-9" using the new public WebDAV API

individual-it · 2020-06-25T06:52:26Z

tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature

+      | uid_file_owner         | Alice           |
+      | uid_owner              | Alice           |
+      | name                   |                 |
+    When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API
    Then the downloaded content should be "Random dat"
    And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403"


Suggested change

And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403"

And the public upload to the last publicly shared file using the new public WebDAV API should fail with HTTP status code "403"

individual-it · 2020-06-25T06:53:10Z

tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature

    Then the downloaded content should be "Random dat"
    And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403"
-    And the public upload to the last publicly shared file using the new public WebDAV API should fail with HTTP status code "403"
+    Then the downloaded content should be "Random dat"


remove this line, that check is done above and fail here because there is no download before this step

PVince81 · 2020-06-25T10:00:12Z

@individual-it thanks for spotting. I already rechecked those bits over and over again for discrepancies but still managed to miss it. I've fixed that location and squashed.

Enabled some tests and tagged others that are not working yet. In some feature files, the "old" and "new" public webdav API tests were split into separate scenarios, as OCIS doesn't support the old public webdav API.

PVince81 · 2020-06-26T09:59:14Z

API tests passed in https://cloud.drone.io/owncloud/ocis-reva/521, merging

PVince81 self-assigned this Jun 18, 2020

This was referenced Jun 18, 2020

public webdav API endpoint does not exist owncloud/ocis-reva#49

Closed

Split old public API webdav tests from new public webdav tests owncloud/ocis-reva#282

Closed

PVince81 force-pushed the tests-adjust-public-share-test-issues branch from 3831752 to dbfa573 Compare June 18, 2020 14:35

PVince81 mentioned this pull request Jun 18, 2020

Update reva to 20200624 owncloud/ocis-reva#279

Merged

PVince81 force-pushed the tests-adjust-public-share-test-issues branch 2 times, most recently from 637bd2e to 5ae0b13 Compare June 18, 2020 20:06

PVince81 force-pushed the tests-adjust-public-share-test-issues branch from 5ae0b13 to cc8730b Compare June 24, 2020 08:27

PVince81 mentioned this pull request Jun 24, 2020

use gateway to resolve public share info cs3org/reva#872

Closed

PVince81 force-pushed the tests-adjust-public-share-test-issues branch from cc8730b to cc15bff Compare June 24, 2020 10:27

PVince81 mentioned this pull request Jun 24, 2020

accessing a public link of a deleted folder via new public link webdav API results in error 500 #36055

Closed

PVince81 force-pushed the tests-adjust-public-share-test-issues branch from cc15bff to f6ca8a3 Compare June 24, 2020 15:35

PVince81 marked this pull request as ready for review June 24, 2020 15:37

PVince81 requested review from individual-it and phil-davis June 24, 2020 15:37

PVince81 changed the title ~~[Tests-only] Adjust public link tests~~ [Tests-only] Adjust public link tests for download, upload and other operations Jun 24, 2020

individual-it requested changes Jun 25, 2020

View reviewed changes

PVince81 force-pushed the tests-adjust-public-share-test-issues branch from f6ca8a3 to 421959d Compare June 25, 2020 09:59

[Tests-only] Adjust public link tests

9d143b4

Enabled some tests and tagged others that are not working yet. In some feature files, the "old" and "new" public webdav API tests were split into separate scenarios, as OCIS doesn't support the old public webdav API.

PVince81 force-pushed the tests-adjust-public-share-test-issues branch from 421959d to 9d143b4 Compare June 25, 2020 10:02

PVince81 requested a review from individual-it June 26, 2020 08:13

PVince81 mentioned this pull request Jun 26, 2020

Point frontend to proxy owncloud/ocis-reva#261

Merged

5 tasks

individual-it approved these changes Jun 26, 2020

View reviewed changes

PVince81 merged commit ad274cb into master Jun 26, 2020

PVince81 deleted the tests-adjust-public-share-test-issues branch June 26, 2020 09:59

PVince81 mentioned this pull request Jun 29, 2020

Api Tests for Links owncloud/product#84

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tests-only] Adjust public link tests for download, upload and other operations #37552

[Tests-only] Adjust public link tests for download, upload and other operations #37552

PVince81 commented Jun 18, 2020 •

edited

Loading

codecov bot commented Jun 18, 2020

codecov bot commented Jun 18, 2020 •

edited

Loading

PVince81 commented Jun 18, 2020

PVince81 commented Jun 24, 2020

PVince81 commented Jun 24, 2020

PVince81 commented Jun 24, 2020

individual-it Jun 25, 2020

individual-it Jun 25, 2020

individual-it Jun 25, 2020

PVince81 commented Jun 25, 2020

PVince81 commented Jun 26, 2020

	When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API
	When the public downloads the last public shared file with range "bytes=0-9" using the new public WebDAV API

	And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403"
	And the public upload to the last publicly shared file using the new public WebDAV API should fail with HTTP status code "403"

[Tests-only] Adjust public link tests for download, upload and other operations #37552

[Tests-only] Adjust public link tests for download, upload and other operations #37552

Conversation

PVince81 commented Jun 18, 2020 • edited Loading

Raised and tagged issues:

TODOs:

codecov bot commented Jun 18, 2020

Codecov Report

codecov bot commented Jun 18, 2020 • edited Loading

Codecov Report

PVince81 commented Jun 18, 2020

PVince81 commented Jun 24, 2020

PVince81 commented Jun 24, 2020

PVince81 commented Jun 24, 2020

individual-it Jun 25, 2020

Choose a reason for hiding this comment

individual-it Jun 25, 2020

Choose a reason for hiding this comment

individual-it Jun 25, 2020

Choose a reason for hiding this comment

PVince81 commented Jun 25, 2020

PVince81 commented Jun 26, 2020

PVince81 commented Jun 18, 2020 •

edited

Loading

codecov bot commented Jun 18, 2020 •

edited

Loading