Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sabre with streaming propfind #36336

Closed
wants to merge 2 commits into from
Closed

Feature/sabre with streaming propfind #36336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bdfdae
Update sabre/dav to dev-master
DeepDiver1975 Oct 25, 2019
5f04383
Enable streaming for propfind
DeepDiver1975 Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/dav/appinfo/v1/webdav.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,6 @@
$event = new \OCP\SabrePluginEvent($server);
\OC::$server->getEventDispatcher()->dispatch('OCA\DAV\Connector\Sabre::authInit', $event);

\Sabre\DAV\Server::$streamMultiStatus = true;
// And off we go!
$server->exec();
1 change: 1 addition & 0 deletions apps/dav/lib/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ public function __construct(IRequest $request, $baseUri) {
));

if ($this->isRequestForSubtree(['files', 'trash-bin', 'public-files'])) {
\Sabre\DAV\Server::$streamMultiStatus = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed I think it would be safer to trigger this with a header to not disturb third party clients

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutly - this is just the simplification for the draft ...

$this->server->addPlugin(new ViewOnlyPlugin(
OC::$server->getLogger()
));
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"deepdiver1975/tarstreamer": "v0.1.1",
"patchwork/jsqueeze": "^2.0",
"lukasreschke/id3parser": "^0.0.3",
"sabre/dav": "^4.0",
"sabre/dav": "dev-master#aa30e99cd94f1abb4cb9fd86875919dffe237707",
"deepdiver/zipstreamer": "^1.1",
"symfony/translation": "^3.4",
"zendframework/zend-inputfilter": "^2.8",
Expand Down
28 changes: 9 additions & 19 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.