-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance tests for checking that share with group and user with same name works #36283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also make some API test scenarios with the sharing API.
Add scenario(s) for when the group name has different case from the user-id. e.g. group User1
as well as group user
It will be good to also have tests that demonstrate how the API behaves.
2375e07
to
c7bd9ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #36283 +/- ##
=========================================
Coverage 65% 65%
Complexity 19772 19772
=========================================
Files 1271 1271
Lines 74696 74696
Branches 1309 1309
=========================================
Hits 48554 48554
Misses 25756 25756
Partials 386 386
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look code - proves that this is a Sharing API bug.
tests/acceptance/features/webUISharingInternalGroups/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
c7bd9ea
to
59e540c
Compare
@ownclouders rebase |
59e540c
to
29db647
Compare
Description
Add acceptance tests for checking that the shares with user and group with same name works.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: