Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for checking that share with group and user with same name works #36283

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Oct 16, 2019

Description

Add acceptance tests for checking that the shares with user and group with same name works.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make some API test scenarios with the sharing API.
Add scenario(s) for when the group name has different case from the user-id. e.g. group User1 as well as group user
It will be good to also have tests that demonstrate how the API behaves.

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #36283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36283   +/-   ##
=========================================
  Coverage        65%      65%           
  Complexity    19772    19772           
=========================================
  Files          1271     1271           
  Lines         74696    74696           
  Branches       1309     1309           
=========================================
  Hits          48554    48554           
  Misses        25756    25756           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.21% <ø> (ø) 19772 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfe0d0...29db647. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look code - proves that this is a Sharing API bug.

@dpakach
Copy link
Contributor Author

dpakach commented Oct 17, 2019

@ownclouders rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants