Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui rename files without skeleton #35474

Merged
merged 1 commit into from
Jun 12, 2019
Merged

webui rename files without skeleton #35474

merged 1 commit into from
Jun 12, 2019

Conversation

haribhandari07
Copy link
Contributor

Description

Do not use skeleton files for webUIRenameFiles to speed up CI

Related Issue

Part of owncloud/QA#622

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Most scenarios upload randomfile.txt. Unfortunately not all, so it cannot go in the Background section.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #35474 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35474   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3550d...7b90d83. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #35474 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35474   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3550d...7b90d83. Read the comment docs.

@haribhandari07
Copy link
Contributor Author

Backport on #35495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants