-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui rename files without skeleton #35474
webui rename files without skeleton #35474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Most scenarios upload randomfile.txt
. Unfortunately not all, so it cannot go in the Background section.
Codecov Report
@@ Coverage Diff @@
## master #35474 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18735 18735
=========================================
Files 1221 1221
Lines 70793 70793
Branches 1288 1288
=========================================
Hits 46503 46503
Misses 23913 23913
Partials 377 377
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35474 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18735 18735
=========================================
Files 1221 1221
Lines 70793 70793
Branches 1288 1288
=========================================
Hits 46503 46503
Misses 23913 23913
Partials 377 377
Continue to review full report at Codecov.
|
Backport on #35495 |
Description
Do not use skeleton files for
webUIRenameFiles
to speed up CIRelated Issue
Part of owncloud/QA#622
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: