-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.2.0] Backport of Remove share permission check from the file up… #35082
[10.2.0] Backport of Remove share permission check from the file up… #35082
Conversation
…load Remove share permission check from the file upload js file. Signed-off-by: Sujith H <sharidasan@owncloud.com>
Original PR #35060 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35082 +/- ##
=================================================
Coverage 64.29% 64.29%
Complexity 20040 20040
=================================================
Files 1285 1285
Lines 76824 76824
Branches 1307 1307
=================================================
Hits 49394 49394
Misses 27049 27049
Partials 381 381
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35082 +/- ##
=================================================
Coverage 64.29% 64.29%
Complexity 20040 20040
=================================================
Files 1285 1285
Lines 76824 76824
Branches 1307 1307
=================================================
Hits 49394 49394
Misses 27049 27049
Partials 381 381
Continue to review full report at Codecov.
|
…load
Remove share permission check from the file upload
js file.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
Remove
sharePermission
checks from the file-upload.js. We are no where using it and there is a problem in the code due to this. When we know its a file, we just have to check the fileinfo ( in the if condition ). The problem this PR tries to address is, when files are uploaded, the file information should be shown. Instead of this, the directory information was shown.This also fixes the cancel button problem in the conflict dialog. The cancel button clicked once cancels the conflict dialog.
Related Issue
Motivation and Context
Remove sharePermission checks from the file-upload.js file. This solves 2 problems:
How Has This Been Tested?
Cancel
button of conflict dialog works correctly.Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: