-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter unavailable users and remove unavailable shares on polling #35010
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35010 +/- ##
============================================
+ Coverage 65.37% 65.37% +<.01%
- Complexity 18622 18626 +4
============================================
Files 1215 1215
Lines 70510 70532 +22
Branches 1295 1295
============================================
+ Hits 46095 46111 +16
- Misses 24041 24047 +6
Partials 374 374
Continue to review full report at Codecov.
|
3519d5c
to
bc8902f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@VicDeo please backport to release-10.2.0 branch |
release-10.2.0: #35073 |
This was backported into |
Description
Protect polling from exploding on unavailable users
Motivation and Context
An unhandled exception has been thrown: TypeError: Argument 1 passed to OCA\Files_Sharing\External\MountProvider::getMountsForUser() must implement interface OCP\IUser, null given,
when UserManager knows nothing about a userIdHow Has This Been Tested?
update oc_share_external set user="Iwouldliketobreakthepolling" limit 1;
Expected
Polling goes through all entries with no termination
Actual
Polling terminates with
TypeError: Argument 1 passed to OCA\Files_Sharing\External\MountProvider::getMountsForUser() must implement interface OCP\IUser, null given
Types of changes
Checklist:
Open tasks: