Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upsert for subshare updates #34952

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Use upsert for subshare updates #34952

merged 1 commit into from
Apr 5, 2019

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Apr 2, 2019

Master port of #34769.

In this instance the share attributes from #33994 are in, which are of type "JSON". This PR's CI run will demonstrate whether upsert properly works with JSON DB fields...

cc @DeepDiver1975 @mrow4a

To avoid race conditions happening exactly between the select and
insert/update.
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #34952 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34952      +/-   ##
============================================
- Coverage     65.38%   65.37%   -0.02%     
+ Complexity    18592    18591       -1     
============================================
  Files          1213     1213              
  Lines         70407    70386      -21     
  Branches       1295     1295              
============================================
- Hits          46034    46013      -21     
  Misses        23999    23999              
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.82% <100%> (-0.02%) 18591 <0> (-1)
Impacted Files Coverage Δ Complexity Δ
lib/private/Share20/DefaultShareProvider.php 98.37% <100%> (-0.06%) 120 <0> (-1)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
lib/private/Server.php 86.68% <0%> (+0.11%) 253% <0%> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22bf45...a4f1a4e. Read the comment docs.

@PVince81
Copy link
Contributor Author

PVince81 commented Apr 2, 2019

no issues, great!

Copy link
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in upsert we trust

@PVince81 PVince81 merged commit 643db7a into master Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the transaction-for-subshares branch April 5, 2019 09:12
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants