Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tests, testing the CORS headers on OCS routes #34697

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Conversation

individual-it
Copy link
Member

Description

Related Issue

part of #34566

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #34697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34697   +/-   ##
=========================================
  Coverage     65.25%   65.25%           
  Complexity    18467    18467           
=========================================
  Files          1207     1207           
  Lines         69928    69928           
  Branches       1280     1280           
=========================================
  Hits          45633    45633           
  Misses        23923    23923           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.66% <ø> (ø) 18467 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73789be...d13471c. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #34697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34697   +/-   ##
=========================================
  Coverage     65.25%   65.25%           
  Complexity    18467    18467           
=========================================
  Files          1207     1207           
  Lines         69928    69928           
  Branches       1280     1280           
=========================================
  Hits          45633    45633           
  Misses        23923    23923           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.66% <ø> (ø) 18467 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73789be...d13471c. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #34697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34697   +/-   ##
=========================================
  Coverage     65.25%   65.25%           
  Complexity    18467    18467           
=========================================
  Files          1207     1207           
  Lines         69928    69928           
  Branches       1280     1280           
=========================================
  Hits          45633    45633           
  Misses        23923    23923           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.66% <ø> (ø) 18467 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73789be...d13471c. Read the comment docs.

@phil-davis
Copy link
Contributor

Backport stable10 #34725

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants