Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust confirm password web UI words and tests #34490

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

phil-davis
Copy link
Contributor

Description

  1. Adjust acceptance test steps that were added in PR Add confirm password after new password #30981 to tidy up some of the English
  2. Change "Passwords does not match" UI message to "Passwords do not match" (correction to the English)

Related Issue

#29901

Motivation and Context

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added/adjusted
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #34492

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34490   +/-   ##
=========================================
  Coverage      65.1%    65.1%           
  Complexity    18338    18338           
=========================================
  Files          1199     1199           
  Lines         69629    69629           
  Branches       1283     1283           
=========================================
  Hits          45335    45335           
  Misses        23920    23920           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 53.1% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.49% <ø> (ø) 18338 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406498a...c7fc570. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34490   +/-   ##
=========================================
  Coverage      65.1%    65.1%           
  Complexity    18338    18338           
=========================================
  Files          1199     1199           
  Lines         69629    69629           
  Branches       1283     1283           
=========================================
  Hits          45335    45335           
  Misses        23920    23920           
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 53.1% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.49% <ø> (ø) 18338 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406498a...c7fc570. Read the comment docs.

@phil-davis phil-davis merged commit c7bfdea into master Feb 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the adjust-confirm-password-webUI branch February 15, 2019 04:09
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants