Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test app:getpath occ command #33615

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Test app:getpath occ command #33615

merged 1 commit into from
Nov 22, 2018

Conversation

skshetry
Copy link
Member

Description

Tests that app:getpath returns path for the app from apps_paths in the config.

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #33615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33615   +/-   ##
=========================================
  Coverage     64.22%   64.22%           
  Complexity    18269    18269           
=========================================
  Files          1193     1193           
  Lines         69077    69077           
  Branches       1277     1277           
=========================================
  Hits          44364    44364           
  Misses        24341    24341           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <ø> (ø) 18269 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6501e8...4a10b97. Read the comment docs.

@skshetry
Copy link
Member Author

@phil-davis fixed, please review again

phil-davis
phil-davis previously approved these changes Nov 22, 2018
@phil-davis
Copy link
Contributor

phil-davis commented Nov 22, 2018

It be broke:

  Scenario: admin checks the path of the given app                                                # /drone/src/tests/acceptance/features/cliProvisioning/getApps.feature:37
    When the administrator checks the location of the "testing" app using the occ command         # OccContext::theAdministratorChecksTheLocationOfTheAppUsingTheOccCommand()
    Then the command should have been successful                                                  # FeatureContext::theCommandShouldHaveBeenSuccessful()
    And the path returned by the occ command should be inside one of the apps paths in the config # OccContext::thePathReturnedByTheOccCommandShouldBeInsideOneOfTheAppsPathInTheConfig()
      Notice: Undefined index: apps_paths in /drone/src/tests/acceptance/features/bootstrap/OccContext.php line 614

@skshetry skshetry dismissed phil-davis’s stale review November 22, 2018 10:31

Please review again. I added to check for default location

@phil-davis phil-davis merged commit ef1bcf5 into master Nov 22, 2018
@phil-davis phil-davis deleted the test-app-get-path branch November 22, 2018 11:44
@phil-davis
Copy link
Contributor

@skshetry please make backport

@phil-davis
Copy link
Contributor

Backport stable10 #33629

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test app:getpath
2 participants