cli Test trashbin

[paurakhsharma]

Description

Add cli tests for trashbin
Related issue: #33536

How Has This Been Tested?

Locally

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Acceptance test

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[paurakhsharma]

@individual-it, I have addressed all the comments. Please review

[paurakhsharma]

@phil-davis, As you can see in the test when we run occ command trashbin:cleanup all users trashbin are cleaned. Isn't this risky? because the administrator can type this by accident. There should be some verification or --all should be added. What do you think? Or do we think administrator are not supposed to make mistakes?

[codecov]

Codecov Report

Merging #33534 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #33534   +/-   ##
=========================================
  Coverage     64.12%   64.12%           
  Complexity    18305    18305           
=========================================
  Files          1193     1193           
  Lines         69155    69155           
  Branches       1277     1277           
=========================================
  Hits          44343    44343           
  Misses        24440    24440           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	52.91% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.42% <ø> (ø)	18305 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8565399...c883aca. Read the comment docs.

[phil-davis]

Or do we think administrator are not supposed to make mistakes?

Real sysadmins never make mistakes ;)

I raised issue #33538

[paurakhsharma]

Backport on: #33548