Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli test for adding, deleting and listing system and app configs #33392

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 2, 2018

Description

create acceptance tests for occ config commands (app set, system set, list...)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #33392 into master will increase coverage by 16.18%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #33392       +/-   ##
=============================================
+ Coverage     47.88%   64.06%   +16.18%     
- Complexity        0    18277    +18277     
=============================================
  Files           109     1190     +1081     
  Lines         10448    69051    +58603     
  Branches       1271     1271               
=============================================
+ Hits           5003    44238    +39235     
- Misses         5075    24443    +19368     
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (+28.44%) 18277 <ø> (+18277) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/config.php 16.39% <0%> (-22.5%) 13% <0%> (+13%)
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0% <0%> (?)
lib/private/Encryption/Keys/Storage.php 88.03% <0%> (ø) 48% <0%> (?)
lib/private/App/CodeChecker/NodeVisitor.php 95.86% <0%> (ø) 54% <0%> (?)
lib/private/RedisFactory.php 0% <0%> (ø) 19% <0%> (?)
apps/dav/lib/Avatars/AvatarNode.php 72% <0%> (ø) 9% <0%> (?)
...s/dav/appinfo/Migrations/Version20170202213905.php 21.05% <0%> (ø) 12% <0%> (?)
apps/dav/lib/Upload/ChunkLocationProvider.php 100% <0%> (ø) 4% <0%> (?)
apps/files/lib/AppInfo/Application.php 39.02% <0%> (ø) 7% <0%> (?)
apps/systemtags/list.php 0% <0%> (ø) 0% <0%> (?)
... and 1073 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd9e26...8d70e94. Read the comment docs.

@dpakach
Copy link
Contributor Author

dpakach commented Nov 2, 2018

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis
Copy link
Contributor

Backport stable10 #33401

@phil-davis
Copy link
Contributor

Weird PHP unit test fails related to thumbnails???
I will try to rebase again...

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis phil-davis merged commit 79fb19c into master Nov 2, 2018
@phil-davis phil-davis deleted the occ-config-key-test branch November 2, 2018 17:14
@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create acceptance tests for occ config commands (app set, system set, list...)
3 participants