[stable10] reset responseXml after receiving a new response #33328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
reviewed
Oct 29, 2018
| @@ -626,6 +626,8 @@ public function getResponse() { | |||
| */ | |||
| public function setResponse($response) { | |||
| $this->response = $response; | |||
| //after a new response rest the response xml | |||
individual-it
force-pushed
the
resetResponseXml
branch
2 times, most recently
from
53f096b
to
09e9436
Compare
10 tasks
|
@phil-davis addressed the typo |
phil-davis
approved these changes
Oct 29, 2018
Codecov Report
@@ Coverage Diff @@
## stable10 #33328 +/- ##
===========================================
Coverage 62.91% 62.91%
Complexity 18867 18867
===========================================
Files 1237 1237
Lines 73960 73960
Branches 1282 1282
===========================================
Hits 46529 46529
Misses 27051 27051
Partials 380 380
Continue to review full report at Codecov.
|
|
@ownclouders rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
ownclouders
force-pushed
the
resetResponseXml
branch
from
09e9436
to
45b0250
Compare
|
Automated rebase with GitMate.io was successful! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #33326