Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliTest user report #33246

Merged
merged 1 commit into from
Oct 24, 2018
Merged

cliTest user report #33246

merged 1 commit into from
Oct 24, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for cliProvisioning userReport using occ commands.

Related issue: #33052

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #33246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33246   +/-   ##
=========================================
  Coverage     64.02%   64.02%           
  Complexity    18187    18187           
=========================================
  Files          1179     1179           
  Lines         68698    68698           
  Branches       1271     1271           
=========================================
  Hits          43987    43987           
  Misses        24341    24341           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.32% <ø> (ø) 18187 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5971d62...806c88f. Read the comment docs.

@individual-it
Copy link
Member

code LGTM @phil-davis please check wording

@paurakhsharma paurakhsharma force-pushed the cliTest-userReport branch 2 times, most recently from 068768f to 4f5d961 Compare October 23, 2018 06:54
@phil-davis phil-davis merged commit 622666f into master Oct 24, 2018
@phil-davis phil-davis deleted the cliTest-userReport branch October 24, 2018 03:57
@paurakhsharma
Copy link
Member Author

Backport on: #33277

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants