Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Don't remove temp file on fail when creating office preview #33234

Merged
merged 1 commit into from
Oct 23, 2018
Merged

[stable10] Don't remove temp file on fail when creating office preview #33234

merged 1 commit into from
Oct 23, 2018

Commits on Oct 20, 2018

  1. Don't remove temp file on fail when creating office preview 

    Whenever an office file preview is created, in case of failure it would
try to delete the input path. In some cases the input path points to a
temporary file and in some other cases it's the original file. Deleting
the original file results in data loss in case the PDF processor had an
error.

The line that deletes the input file was removed now because there is no
need to remove temporary files because the TempManager will have all
temporary files cleant up in the shutdown handler at the end of the PHP
request.
    Vincent Petry committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    493aabd View commit details
    Browse the repository at this point in the history