Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for removeFromGroup #33147

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for cliProvisioning removeFromGroup using occ commands.

Related issue: #33052

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a scenarios for:

  • when the user and group exist, but the user is not in the group, and we try to remove them from the group.
  • when the group exists but the user does not exist

@paurakhsharma paurakhsharma force-pushed the occTest-cliProvisioning-removeFromGroup branch from 9313f5c to 831702a Compare October 11, 2018 05:57
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #33147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33147   +/-   ##
=========================================
  Coverage     64.12%   64.12%           
  Complexity    18720    18720           
=========================================
  Files          1184     1184           
  Lines         70437    70437           
  Branches       1270     1270           
=========================================
  Hits          45171    45171           
  Misses        24896    24896           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (ø) 18720 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a24ea...cbee7cc. Read the comment docs.

@paurakhsharma paurakhsharma force-pushed the occTest-cliProvisioning-removeFromGroup branch from 831702a to 5066fba Compare October 11, 2018 06:00
Then the command should have been successful
And the command output should contain the text 'Member "brand-new-user" could not be found in group "new-group"'

Scenario: admin tries to remove a user who does exit from an existing group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who does not exist

@paurakhsharma paurakhsharma force-pushed the occTest-cliProvisioning-removeFromGroup branch from 5066fba to cbee7cc Compare October 11, 2018 06:04
@phil-davis phil-davis merged commit ca99950 into master Oct 11, 2018
@phil-davis phil-davis deleted the occTest-cliProvisioning-removeFromGroup branch October 11, 2018 07:19
@paurakhsharma
Copy link
Member Author

Backport on: #33152

@lock lock bot locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants