Add tests for getUsers #33146
Merged
Add tests for getUsers #33146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paurakhsharma
commented
Oct 11, 2018
| @@ -425,9 +436,18 @@ public function theAppsReturnedByTheOccCommandShouldInclude(TableNode $appListTa | |||
| public function theUsersReturnedByTheOccCommandShouldBe(TableNode $useridTable) { | |||
| $lastOutput = $this->featureContext->getStdOutOfOccCommand(); | |||
| $lastOutputUsers = \json_decode($lastOutput, true); | |||
| $result = []; | |||
| // check if an array is a multi-dimentional array with inner array key 'displayName' | |||
| if (\array_column($lastOutputUsers, 'displayName')) { | |||
There was a problem hiding this comment.
This check is because when we run occ command to get users from a group we get a single dimensional array but when we run occ command to get all users on ownCloud server we get multi-dimensional array
phil-davis
reviewed
Oct 11, 2018
| @@ -425,9 +436,18 @@ public function theAppsReturnedByTheOccCommandShouldInclude(TableNode $appListTa | |||
| public function theUsersReturnedByTheOccCommandShouldBe(TableNode $useridTable) { | |||
| $lastOutput = $this->featureContext->getStdOutOfOccCommand(); | |||
| $lastOutputUsers = \json_decode($lastOutput, true); | |||
| $result = []; | |||
| // check if an array is a multi-dimentional array with inner array key 'displayName' | |||
There was a problem hiding this comment.
s/dimentional/dimensional
paurakhsharma
force-pushed
the
occTest-cliProvisioning-getUsers
branch
from
a976333
to
834e454
Compare
Codecov Report
@@ Coverage Diff @@
## master #33146 +/- ##
=========================================
Coverage 64.12% 64.12%
Complexity 18720 18720
=========================================
Files 1184 1184
Lines 70437 70437
Branches 1270 1270
=========================================
Hits 45171 45171
Misses 24896 24896
Partials 370 370
Continue to review full report at Codecov.
|
phil-davis
approved these changes
Oct 11, 2018
|
Backport on: #33148 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more tests for cliProvisioning getUsers using occ commands.
Related issue: #33052
How Has This Been Tested?
Locally
Types of changes
Checklist: