Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occ test cli provisioning get user groups #33129

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for cliProvisioning getUserGroups using occ commands.

Related issue: #33052

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #33129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33129   +/-   ##
=========================================
  Coverage     64.13%   64.13%           
  Complexity    18725    18725           
=========================================
  Files          1186     1186           
  Lines         70474    70474           
  Branches       1270     1270           
=========================================
  Hits          45201    45201           
  Misses        24903    24903           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.41% <ø> (ø) 18725 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca5688...8d0ef20. Read the comment docs.

@paurakhsharma paurakhsharma force-pushed the occTest-cliProvisioning-getUserGroups branch from d8cf86e to 8d0ef20 Compare October 10, 2018 10:47
@paurakhsharma
Copy link
Member Author

Backport on: #33131

@phil-davis phil-davis merged commit 8537019 into master Oct 10, 2018
@phil-davis phil-davis deleted the occTest-cliProvisioning-getUserGroups branch October 10, 2018 11:27
@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants