Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test acceptance cli infrastructure #33041

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 7, 2018

Description

  1. Add a make test-acceptance-cli Makefile target.
  2. Implement the pieces in .drone.yml behat.yml run.sh to know about the cli acceptance test suite type.
  3. Make a cliProvisioning suite to get started.
  4. Make addUser.feature with a couple of "easy" scenarios

Related Issue

Motivation and Context

See issue, we need acceptance tests that test occ command behaviour.

How Has This Been Tested?

make test-acceptance-cli

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Note: this PR branch is on top of #33038 - when that is merged, the 1st commit here will "rebase away".

@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #33041 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33041   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18724    18724           
=========================================
  Files          1185     1185           
  Lines         70460    70460           
  Branches       1270     1270           
=========================================
  Hits          45198    45198           
  Misses        24892    24892           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18724 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8655e9...9415c8c. Read the comment docs.

@paurakhsharma paurakhsharma merged commit 782913b into master Oct 8, 2018
@paurakhsharma paurakhsharma deleted the test-acceptance-cli-infrastructure branch October 8, 2018 04:17
@phil-davis
Copy link
Contributor Author

Backport stable10 #33044

@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants