Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump behat/mink-selenium2-driver dev-master #33002

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

phil-davis
Copy link
Contributor

Description

A few commits were added recently to dev-master of behat/mink-selenium2-driver
We follow that because there are other not-yet-released commits there that are needed.
So see if our tests still work with the newer commits.

Motivation and Context

Make sure dependency updates work.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #33002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33002   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18724    18724           
=========================================
  Files          1185     1185           
  Lines         70460    70460           
  Branches       1270     1270           
=========================================
  Hits          45198    45198           
  Misses        24892    24892           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18724 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f4db7...a446934. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Need to leave this a few days, just to make sure that the dev-master commits in the repo stay there like they are now. Then we can decide to take this.

@phil-davis phil-davis force-pushed the mink-selenium2-driver-dev-master-20181004 branch from 373aede to 5fef16e Compare October 6, 2018 00:40
@phil-davis
Copy link
Contributor Author

The upstream dev-master has been stable for the last days, so this looks OK.

Backport stable10 #33045

@phil-davis phil-davis merged commit 16e204e into master Oct 8, 2018
@phil-davis phil-davis deleted the mink-selenium2-driver-dev-master-20181004 branch October 8, 2018 06:38
@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants