check file existence after upload with wrong checksums #32723

individual-it · 2018-09-17T10:01:24Z

Description

when an upload should not work (in this case because of wrong checksums), we should not only check the status code but also if the file exists or not

do not trust the code

🤖

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Backport (if applicable set "backport-request" label and remove when the backport was done)

individual-it · 2018-09-17T10:10:23Z

backport in #32725

check file existence after upload with wrong checksums

cbc80f8

individual-it self-assigned this Sep 17, 2018

individual-it added 3 - To Review backport-request dev:acceptance-tests QA:team labels Sep 17, 2018

individual-it added this to the QA milestone Sep 17, 2018

individual-it requested a review from phil-davis September 17, 2018 10:04

individual-it mentioned this pull request Sep 17, 2018

[stable10] check file existence after upload with wrong checksums #32725

Merged

individual-it removed the backport-request label Sep 17, 2018

ownclouders mentioned this pull request Sep 17, 2018

acceptance tests that check upload overwriting with checksums #32724

Closed

phil-davis approved these changes Sep 17, 2018

View reviewed changes

phil-davis merged commit 5c3cf43 into master Sep 17, 2018

phil-davis deleted the testNotExistingOfFileOnErrorChecksum branch September 17, 2018 10:42

ownclouders mentioned this pull request Sep 19, 2018

uploading an existing file after a search results in wrong sums in files table #32756

Open

lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019